Skip to content

build: Don't use cache for files depending on Release Registry #15124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 3, 2025
Merged

build: Don't use cache for files depending on Release Registry #15124

merged 6 commits into from
Oct 3, 2025

Conversation

@lcian
Copy link
Member

@lcian lcian commented Oct 3, 2025 •
edited
Loading

DESCRIBE YOUR PR

Close DOCS-2288

@vercel
Copy link

vercel bot commented Oct 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Oct 3, 2025 2:30pm
sentry-docs Ready Ready Preview Comment Oct 3, 2025 2:30pm

@lcian lcian changed the title build: Don't cache files with content from release registry build: Always rebuild files with content from release registry Oct 3, 2025
@lcian lcian changed the title build: Always rebuild files with content from release registry build: Avoid cache for files with content from release registry Oct 3, 2025
@codecov
Copy link

codecov bot commented Oct 3, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 198 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.15MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.94MB 204 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/ZiepWGVwPLHCEMekI_igo/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/ZiepWGVwPLHCEMekI_igo/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/qD4BGeLJF0B3N8Q7ETbTN/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/qD4BGeLJF0B3N8Q7ETbTN/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
9567.js 213 bytes 21.52kB 1.0%

Files in 9567.js:

  • ./src/mdx.ts → Total Size: 25.08kB

@linear
Copy link

linear bot commented Oct 3, 2025

DOCS-2288 Caching issue with incorrect package version in docs

@lcian lcian changed the title build: Avoid cache for files with content from release registry build: Skip cache for files with content from release registry Oct 3, 2025
@lcian lcian changed the title build: Skip cache for files with content from release registry build: Don't use cache for files depending on Release Registry Oct 3, 2025
@lcian lcian marked this pull request as ready for review October 3, 2025 13:44
@lcian lcian requested a review from BYK October 3, 2025 13:45
seer-by-sentry[bot]
seer-by-sentry bot reviewed Oct 3, 2025
View reviewed changes
BYK
BYK approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@lcian lcian enabled auto-merge (squash) October 3, 2025 14:05
@lcian lcian merged commit 42c11da into master Oct 3, 2025
15 checks passed
@lcian lcian deleted the lcian/build/dont-cache branch October 3, 2025 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@seer-by-sentry seer-by-sentry[bot] seer-by-sentry[bot] left review comments

@BYK BYK BYK approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lcian @BYK